Skip to content

Do not allow dashes in file names #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Do not allow dashes in file names #1359

merged 1 commit into from
Jun 16, 2025

Conversation

alexandear
Copy link
Contributor

This PR renames decompression-bomb.go to decompression_bomb.go and directory-traversal.go to directory_traversal.go for consistency. Also, enables revive.filename-format to forbid - in filenames.

❯ golangci-lint run
rules/decompression-bomb.go:15:9: filename-format: Filename decompression-bomb.go is not of the format ^[a-z][_a-z0-9]*.go$. (revive)
package rules
        ^
rules/directory-traversal.go:1:9: filename-format: Filename directory-traversal.go is not of the format ^[a-z][_a-z0-9]*.go$. (revive)
package rules
        ^
2 issues:
* revive: 2

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.15%. Comparing base (1216c9b) to head (5e0cc22).
Report is 80 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   68.49%   63.15%   -5.35%     
==========================================
  Files          75       74       -1     
  Lines        4384     5179     +795     
==========================================
+ Hits         3003     3271     +268     
- Misses       1233     1780     +547     
+ Partials      148      128      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ccojocar ccojocar merged commit 4a8cb46 into securego:master Jun 16, 2025
6 checks passed
@alexandear alexandear deleted the enable-revive-filename-format branch June 16, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccojocar ccojocar ccojocar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @codecov-commenter @ccojocar